-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify jet daughter processing in DeepBoostedJet #28035
Simplify jet daughter processing in DeepBoostedJet #28035
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28035/11962
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
8af7892
to
c84f658
Compare
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28035/11963
|
A new Pull Request was created by @hqucms (Huilin Qu) for master. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@hqucms ; can this be tested in any standard workflow, or do you have to run something manually? Please provide a recipe for testing, in case this is not run in one of the automatically tested workflows. |
@perrotta DeepAK8 is run in the standard MiniAOD/NanoAOD workflows now so it should be covered. |
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
- Use original PackedCandidate instead of puppi scaled ones. (needs cms-sw/cmssw#28035) - Use uncorr_pt to sort subjets. - Use calibrated hcalFrac. (11_0_X) - Add Top_bl matching def. - Return matched parton for QCD labels.
PR description:
This PR simplifies the treatment of Puppi jet daughters in DeepAK8. In the past, we rely on a postfix string to distinguish whether the AK8 jets have puppi scaled daughters or not, which is quite fragile. Now we unifies it to always first get the original candidate (via the
key()
, inspired by @raggleton's RekeyJets) and then scaled it by the puppi weight.PR validation:
Tested in a boosted TT sample and no change in the discriminator outputs found.